Skip to content

Conversation

TheLastGimbus
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Add a new page for gh config

I could not figure out what does --host option do - neither does it say anywhere in the official documentation. If someone ever knew, it would be nice to fill that

Ref: #4701

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 24, 2020
Copy link
Collaborator

@navarroaxel navarroaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheLastGimbus, I left some comments.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm just wondering if it'd be worth adding two examples to the top for generic get/set to cover any future additional config properties. i.e.

- Get a specific configuration value:

`gh config get {{key}}`

- Set a specific configuration value:

`gh config set {{key}} {{value}}`

Also, I can't find the --host option that was mentioned, so not sure what that is. 🤷🏻

@navarroaxel navarroaxel requested a review from owenvoke October 26, 2020 11:57
@TheLastGimbus
Copy link
Contributor Author

I added set example - get is obvious to figure out from it

Also, I can't find the --host option

When you type gh config set --help - -h, --host string Set per-host setting - I tried if it's about repo-specific, but couldn't get it to work - it's probably for different Enterprise hosts 🤷

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ah, yeah. I'd assume that's for per-Enterprise settings. 👍🏻 We can probably exclude that though for now.

@TheLastGimbus
Copy link
Contributor Author

TheLastGimbus commented Oct 26, 2020

Hey, so, can someone merge this? @owenvoke? Everything is approved soo...

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheLastGimbus!

@sbrl sbrl merged commit 25ca1cc into tldr-pages:master Oct 27, 2020
@owenvoke
Copy link
Member

Sorry, I was planning on merging but forgot to after I'd approved it. Thanks @TheLastGimbus 👍🏻

@TheLastGimbus TheLastGimbus deleted the gh-config branch October 28, 2020 21:59
@navarroaxel navarroaxel mentioned this pull request Jan 10, 2021
14 tasks
@dmmqz dmmqz mentioned this pull request Sep 18, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants