-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
gh-config: add page #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-config: add page #4837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheLastGimbus, I left some comments.
Co-authored-by: Axel Navarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm just wondering if it'd be worth adding two examples to the top for generic get
/set
to cover any future additional config properties. i.e.
- Get a specific configuration value:
`gh config get {{key}}`
- Set a specific configuration value:
`gh config set {{key}} {{value}}`
Also, I can't find the --host
option that was mentioned, so not sure what that is. 🤷🏻
I added
When you type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ah, yeah. I'd assume that's for per-Enterprise settings. 👍🏻 We can probably exclude that though for now.
Hey, so, can someone merge this? @owenvoke? Everything is approved soo... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @TheLastGimbus!
Sorry, I was planning on merging but forgot to after I'd approved it. Thanks @TheLastGimbus 👍🏻 |
common/
,linux/
, etc.)Add a new page for
gh config
I could not figure out what does
--host
option do - neither does it say anywhere in the official documentation. If someone ever knew, it would be nice to fill thatRef: #4701