-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
gh-issue: add page #4836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-issue: add page #4836
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheLastGimbus, I left some comments.
Co-authored-by: Axel Navarro <[email protected]>
I commited some of changes, but for the rest (and also applying for my 2 other I'm new here, and I'm obiously not a maintainer, but from what I see (or would want) TL;DR pages to be - a quick, beginner friendly/human-readable examples for how to do common tasks That's why I
That's my point of view - but if this repo has strict design ways and you want me to change them to be more technical - it's all right 👍 |
@TheLastGimbus Don't worry, just apply a few style changes that I suggested and we can check if the page is correct or need more work. |
Co-authored-by: Axel Navarro <[email protected]>
Co-authored-by: Axel Navarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page! I've left a comment below for you to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the requested change has been resolved. 👍🏻
@sbrl, is this ok to merge? Looks like your change has been applied. 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks for reminding me @owenvoke!
Looks ok to me :D
common/
,linux/
, etc.)Add a new page for
gh issue
Ref: #4701