Skip to content

Conversation

@sanehab
Copy link
Contributor

@sanehab sanehab commented Sep 30, 2020

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented Sep 30, 2020

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

Hello! I've noticed something unusual when checking this PR:

  • The file pages/common/git-update-ref does not have a .md extension.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/git-update-ref.md:13: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sanehab, thanks for the new page. Just a couple of changes to update the examples to use our token syntax, but other than that, it looks great. 👍🏻

@owenvoke owenvoke added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Sep 30, 2020
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. 🥳

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sanehab!

@sbrl sbrl merged commit 79aea48 into tldr-pages:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants