Skip to content

Conversation

@alison-li
Copy link

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@agnivade agnivade added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Aug 15, 2020
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please take a look at the comments.

@alison-li alison-li requested a review from agnivade August 18, 2020 22:35
@agnivade
Copy link
Member

It looks like a lot of unrelated commits got in with the latest changes.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alison-li - the page itself looks fine to me! However I think an interactive rebase is required to remove the extra commits. You probably want git rebase -i 709db14

If you have issues with that, we're happy to do it while merging if you like :-)

@alison-li
Copy link
Author

@sbrl Thanks for the tip! I actually am having some trouble and would love to take you up on that and to learn how to do it properly myself for next time. 😅 Sorry for any inconvenience!

@einverne
Copy link
Member

hi, @alison-li thank you for the new page, I suggest that you can split your commits into different parts and pull-request for each change.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted, @alison-li :-)

That was an interesting one! I did this using a series of interactive git rebases, and tig as a TUI to help me keep track of what was doing while rewording and to make sure it's all in the right order.

Some resources if you'd like to get better at git:

@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Sep 6, 2020
@navarroaxel navarroaxel requested a review from sbrl September 7, 2020 11:19
@sbrl sbrl merged commit 9c7e508 into tldr-pages:master Sep 9, 2020
@bl-ue bl-ue removed the waiting Issues/PRs with Pending response by the author. label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants