-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
git-send-email: add page #4265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-send-email: add page #4265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please take a look at the comments.
|
It looks like a lot of unrelated commits got in with the latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alison-li - the page itself looks fine to me! However I think an interactive rebase is required to remove the extra commits. You probably want git rebase -i 709db14
If you have issues with that, we're happy to do it while merging if you like :-)
|
@sbrl Thanks for the tip! I actually am having some trouble and would love to take you up on that and to learn how to do it properly myself for next time. 😅 Sorry for any inconvenience! |
|
hi, @alison-li thank you for the new page, I suggest that you can split your commits into different parts and pull-request for each change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorted, @alison-li :-)
That was an interesting one! I did this using a series of interactive git rebases, and tig as a TUI to help me keep track of what was doing while rewording and to make sure it's all in the right order.
Some resources if you'd like to get better at git:
- git rebase tutorial
- Learn Git Branching
- tig
- Another personal favourite command:
git log --oneline --graph --decorate
|
Hi all! This thread has not had any recent activity. |
common/,linux/, etc.)