Skip to content

Conversation

tonytheleg
Copy link
Contributor

Per issue #2213, adding runcon

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Per issue tldr-pages#2213, adding runcon
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

accidentally added a bad character
@tldr-bot
Copy link

tldr-bot commented Oct 1, 2019

The build for this PR has failed with the following error(s):

Error: Parse error on line 12:
...TYPE_t {{{command}}` `- Specify the ro
-----------------------^
Expecting 'NEWLINE', 'TEXT', 'DASH', 'BACKTICK', got 'COMMAND_TEXT'
pages/linux/runcon.md:11: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Oct 1, 2019

The build for this PR has failed with the following error(s):

Error: Parse error on line 12:
...TYPE_t {{{command}}` `- Specify the ro
-----------------------^
Expecting 'NEWLINE', 'TEXT', 'DASH', 'BACKTICK', got 'COMMAND_TEXT'
pages/linux/runcon.md:11: TLDR103 Command example is missing its closing backtick

Please fix the error(s) and push again.

dang trailing spaces
@andrik andrik added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 2, 2019
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @tonytheleg ! I've left some comments below for you to review.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tonytheleg!

@mebeim mebeim dismissed agnivade’s stale review October 28, 2019 23:08

Comment addressed.

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the page since it has been sitting here for a while. I've also dismissed @agnivade's review since I've addressed his comment, but he's unfortunately currently locked out of his GitHub account. It looks good to merge to me, what do you guys think?

@mebeim
Copy link
Member

mebeim commented Oct 29, 2019

Merging since this already has 4 approvals (+ 1 from @agnivade via Gitter).

@mebeim mebeim merged commit 5fec60d into tldr-pages:master Oct 29, 2019
@andrik
Copy link
Collaborator

andrik commented Oct 29, 2019

Nice one guys, this PR closes #2213

@mebeim
Copy link
Member

mebeim commented Oct 29, 2019

Woah really? Didn't notice, nice! 🚀

@Managor Managor mentioned this pull request Oct 7, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants