Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ul: add page #3282

Merged
merged 3 commits into from
Oct 3, 2019
Merged

ul: add page #3282

merged 3 commits into from
Oct 3, 2019

Conversation

johncurcio
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@tldr-bot
Copy link

tldr-bot commented Oct 1, 2019

The build for this PR has failed with the following error(s):

pages/linux/ul.md:4: TLDR004 Command descriptions should end in a period
pages/linux/ul.md:6: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/linux/ul.md:10: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

@andrik andrik added the new command Issues requesting creation of a new page. label Oct 1, 2019
@andrik
Copy link
Collaborator

andrik commented Oct 1, 2019

Hi @johncurcio

Thank you for your submission. Looks like linter founded some issues, would you please fix and push again?

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pages/linux/ul.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Aracki Aracki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @johncurcio for this one!

Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbrl sbrl merged commit 629f5ed into tldr-pages:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants