Skip to content

Conversation

@principis
Copy link
Contributor

@principis principis commented Jun 23, 2019

Fixes #3125
Moved rename to the linux folder and added explanation for rename.ul.
Added rename.ul

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Let me know if any changes are necessary! :)

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/linux/rename.md:4: TLDR004 Command descriptions should end in a period
pages/linux/rename.ul.md:5: TLDR004 Command descriptions should end in a period
pages/linux/rename.ul.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

Moved rename to the linux folder and added explanation for rename.ul.
Added rename.ul
@andrik andrik added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Jun 24, 2019
Co-Authored-By: Waldir Pimenta <[email protected]>
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @principis!

Thanks for helping untangle this. I've left a comment below for you to review.

Co-Authored-By: Starbeamrainbowlabs <[email protected]>
@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/linux/rename.ul.md:5: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, totally forgot about the end in a full stop thing.

I've committed a fix for you, if that's ok @principis?

@principis
Copy link
Contributor Author

@sbrl is fine for me. I still need to make some changes according to what's discussed in #3125 but I'm currently short on time. I'll finish it friday or saturday. (Rename the files, and add perl-rename)

Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @principis for taking the time to address this. Please see my comments below.

@principis
Copy link
Contributor Author

@mebeim thanks for all the fixes. I just resolved everything because I changed a lot to what was discussed in #3125

I was thinking about an example for prename/perl-rename but couldn't immediately find something. According to the man page (prename/perl-rename), it shouldn't overwrite files without asking but in my testing it did... Can someone confirm?

@mebeim
Copy link
Member

mebeim commented Jul 7, 2019

By the way, I prename does indeed rename without a warning on my machine (Debian 9.9).

@mebeim
Copy link
Member

mebeim commented Jul 17, 2019

Ping @principis could you please apply my last unresolved suggestion so that this can finally be merged?

@principis
Copy link
Contributor Author

@mebeim I'm so sorry, I've had terrible internet the past few weeks because I'm not at home... (~35 KB/s) and few time. I thought I still wanted to make some changes, but it's difficult to do anything from here so merging is fine. Sorry for the delay.

Co-Authored-By: Marco Bonelli <[email protected]>
@mebeim
Copy link
Member

mebeim commented Jul 18, 2019

@principis no problem at all! Thank you again for your work 😄

@mebeim mebeim merged commit 89c43ca into tldr-pages:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The 'rename' command has multiple different versions

7 participants