-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
rename: fix 'rename' command has two different versions #3126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The build for this PR has failed with the following error(s): Please fix the error(s) and push again. |
Moved rename to the linux folder and added explanation for rename.ul. Added rename.ul
Co-Authored-By: Waldir Pimenta <[email protected]>
sbrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @principis!
Thanks for helping untangle this. I've left a comment below for you to review.
Co-Authored-By: Starbeamrainbowlabs <[email protected]>
|
The build for this PR has failed with the following error(s): Please fix the error(s) and push again. |
sbrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, totally forgot about the end in a full stop thing.
I've committed a fix for you, if that's ok @principis?
mebeim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @principis for taking the time to address this. Please see my comments below.
|
@mebeim thanks for all the fixes. I just resolved everything because I changed a lot to what was discussed in #3125 I was thinking about an example for prename/perl-rename but couldn't immediately find something. According to the man page (prename/perl-rename), it shouldn't overwrite files without asking but in my testing it did... Can someone confirm? |
|
By the way, I |
|
Ping @principis could you please apply my last unresolved suggestion so that this can finally be merged? |
|
@mebeim I'm so sorry, I've had terrible internet the past few weeks because I'm not at home... (~35 KB/s) and few time. I thought I still wanted to make some changes, but it's difficult to do anything from here so merging is fine. Sorry for the delay. |
Co-Authored-By: Marco Bonelli <[email protected]>
|
@principis no problem at all! Thank you again for your work 😄 |
Fixes #3125
Moved rename to the linux folder and added explanation for rename.ul.
Added rename.ul
common/,linux/, etc.)Let me know if any changes are necessary! :)