-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfkill: add page #2502
rfkill: add page #2502
Conversation
pages/linux/rfkill.md
Outdated
|
||
- Filter by columns: | ||
|
||
`rfkill -o {{COL1,COL2,COL3}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a concrete example would be better here?
pages/linux/rfkill.md
Outdated
|
||
- List devices: | ||
|
||
`rfkill list {{all}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all be in tokens here ? What other values are allowed ?
pages/linux/rfkill.md
Outdated
|
||
`rfkill list {{all}}` | ||
|
||
- Block by type (e.g. bluetooth, wlan): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Block device by type .. " just to be slightly clearer
pages/linux/rfkill.md
Outdated
|
||
`rfkill -o {{COL1,COL2,COL3}}` | ||
|
||
- Output JSON: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Output in JSON format"
Apply suggestions and remove `rfkill list` which is deprecated.
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BinaryBrain 😺
@BinaryBrain - Kindly take care of the travis failure. :) |
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being edited.The page follows the contributing guidelines.