-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
cluster, diffimg, dijkstra, dotty, gvedit, gvgen, gvmap: add page #18502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster, diffimg, dijkstra, dotty, gvedit, gvgen, gvmap: add page #18502
Conversation
The build for this PR failed with the following error(s) at commit
Please fix the error(s) and push again. |
…fix blank line errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let it slide this time, but next time limit the new page count in a PR to 5 to make it less taxing to review
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
@Managor, Thanks for your review, I've incorporated all changes except one, I require your inputs on changes to Understood, I'll keep the page limit in mind for future PRs. I suggest you add this to the content guidelines. |
Co-authored-by: Managor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mnemonics allow the user to memorize what the option is short for. https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#short-option-mnemonics
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
Co-authored-by: Managor <[email protected]>
@Managor, Thanks for your detailed suggestions & prompt approval! |
Hi @Managor, following up on this, is there anything required from my side to initiate the 2nd review to get the PR merged? |
No. The other reviewers just haven't noticed this PR. |
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
Co-authored-by: Lena Pastwa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Appreciate the detailed review! Let me know if there any other pre-requisites before merging this branch. |
Nothing, I just want to wait for a third maintainer to take a look at this, since the PR is pretty big. |
Ah, cool 👍 |
Hi!
W.r.t issue #2580 , I've added the commands
cluster
,diffimg
,dijkstra
,dotty
,gvedit
,gvgen
,gvmap
. A few notes:dotty
graph editor has been deprecated. I've highlighted this indotty
's documentation as a separate Note. (I think people now usegvedit
or any other online service for this)pages/common/
directory as per convention.Let me know if there are any other code changes/modalities required from my side.
P.S.
Also, please clarify if I need to agree to the the CLA for tldr-pages/tldr as well.
common
,linux
,osx
,windows
,sunos
,android
, etc.