Skip to content

Conversation

cyqsimon
Copy link
Collaborator

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): policycoreutils-python-utils-3.6

I also updated semanage.md and getenforce.md to reference these new pages.

@cyqsimon cyqsimon requested a review from spageektti as a code owner May 25, 2024 11:18
@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels May 25, 2024
@cyqsimon cyqsimon mentioned this pull request May 25, 2024
43 tasks
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating these pages. I only have one note regarding the posting of examples regarding other commands. I think it is not a good idea for the sake of clarity. Isn't it better to put this command with a description in see also?

Copy link
Collaborator Author

@cyqsimon cyqsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included some of these foreign commands because they are likely to be used in conjunction, and there are quite a few precedences for doing this, e.g.

After all the ultimate goal here is to help the user do the thing they want to do, as quickly as possible. And if that involves running a related command, I think it's justified to have it in here, especially when we have plenty of free space for it.

@spageektti spageektti merged commit 1c4f439 into tldr-pages:main May 26, 2024
@cyqsimon cyqsimon deleted the selinux-new-pages branch May 26, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants