Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delpart: add page #11135

Merged
merged 3 commits into from
Oct 21, 2023
Merged

delpart: add page #11135

merged 3 commits into from
Oct 21, 2023

Conversation

FarzadHayat
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.38.1

For delpart command as part of util-linux in #2214
Sudo is necessary to get correct permission level.

I think adding a concrete example like:
sudo delpart /dev/sda 1
would help provide more clarity on how to use the command.
I'm not sure whether this would fit into the tldr page structure though.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 21, 2023
pages/linux/delpart.md Outdated Show resolved Hide resolved
pages/linux/delpart.md Outdated Show resolved Hide resolved
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution.

LGTM, after @acuteenvy's suggestions.

@sebastiaanspeck sebastiaanspeck merged commit 44e52ce into tldr-pages:main Oct 21, 2023
4 checks passed
@FarzadHayat FarzadHayat deleted the add-delpart branch October 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants