[CI] Pin Cython version to fix Cython compilation #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-Sturge
changed the title
lhutton1
approved these changes
Jul 26, 2023
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython.
Adding pins to Centos script and Conda environment as well, because the first revision of this patch fails CI.
Due to failing CI, removing the pin from the conda recipe.
Removing the pin from the Conda build-environment, but reinstating the pin in the Conda recipe.
Now specifying the minimum version that should be used, to keep it in line with the other changes, but allow Conda to find the latest working version.
Pin the version of Cython used during standard Python pip install and bump the version of MacOS used for the build compilation.
Liam-Sturge
force-pushed
the
Pin_Cython_version_to_fix_Ubuntu_Cython_compilation
branch
from
c6c3066 to
43a209a
Compare
Contributor
Author
|
Closing this PR as another has been raised in its place that doesn't exceed the scope of the patch and try to fix other CI issues too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython.
Cython has been pinned for TVM in PR: 15353 until a working fix is created. This patch replicates the changes for tlcpack installation, as we are seeing the same Cython errors when trying to use tlcpack Ubuntu Docker images.
cc @leandron @areusch @konturn @Mousius @lhutton1 @tqchen