-
Notifications
You must be signed in to change notification settings - Fork 39
Blocker: TLA+ model checking (web) view not populated when model-checking again #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@alygin Any way we can help with this issue? |
I took a stab at this tonight and I agree with the VSCode authors that webviews are a clutch. The issue is gone when, instead of caching the webview, a new one is always created. There are a few issues related to webviews that popped up after the 1.47 release, but they don't fit. Perhaps, the root cause is tightened security related to the Here is a radical idea... Why not ditch the error-view in favor of opening (an enhanced) SpecTE.tla in the regular editor in combination with a couple of editor enhancements such as folding, highlighting of modified vars, ... This would also make it a lot simpler to add trace expression evaluation to the extension. |
@lemmy, you're absolutely right. The problem is caused by resource paths invalidation after web view closing, and dropping the page source cache solves the issue. Regarding the radical idea, I thought about possible ways to abstain from using a web view when I just started working on the extension, but I failed to come up with a good UI that would be only based on the text editor features. But VS Code has been rapidly evolving since then, so I guess, some interesting ideas might be implemented now. Though, despite my love of text-based UIs, I honestly don't see how the web view could be completely replaced here without losing usability. |
BTW, WebView is finding its way to other parts of VS Code: 46585. I hope it'll become more robust as it becomes more widely used. |
Fixed in v1.5.1. Please, reopen the issue if the problem still remains in your environment. |
On Windows (and Linux) with VSCode newer than
1.46.1
and any version of this extension in1.5.0..1.5.1-alpha-2
, re-running model-checking results in an empty web view (iff the web view gets closed in between). The Windows task manager confirms that TLC spawns and terminates correctly.(Downgrading to VSCode 1.46.1 reliably fixes the issue)
The text was updated successfully, but these errors were encountered: