improve ISO8601 parsing #4
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I have added the capability for the
parsetime
library to parse inputs in the following format:Changes
This was done by adding the following code to the
parseISO8601
function:The
zone
regular expression also needed to be updated. Are you in agreement with this change? All tests still pass (see below).I also fixed a misspelled word:
February
.In order to add this feature, I needed to understand the code base. To that end, I asked claude.ai to generate comments for most of the functions. I then read over these comments and they seem accurate. I can remove these from the PR if you don't want them in there or just remove the
Example usage
sections of the comments.Testing
I added two tests in
parsetime_test.go
to verify the new format. All tests passed when runninggo test
. Can you please verify that these are good tests?