Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonicalize/canonicalize! #86

Merged
merged 4 commits into from
Oct 8, 2018
Merged

Add canonicalize/canonicalize! #86

merged 4 commits into from
Oct 8, 2018

Conversation

tkoolen
Copy link
Owner

@tkoolen tkoolen commented Oct 8, 2018

Used to re-express Parametron.Functions types in a standard form. Useful for easy comparison, among other things.

CC: @timholy. Decided against overloading == and hash, and remembered that @rdeits and I had implemented something similar for MathOptInterface functions.

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #86 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   97.76%   97.86%   +0.09%     
==========================================
  Files           8        9       +1     
  Lines         493      515      +22     
==========================================
+ Hits          482      504      +22     
  Misses         11       11
Impacted Files Coverage Δ
src/functions.jl 99.24% <100%> (+0.05%) ⬆️
src/util.jl 100% <100%> (ø)
src/model.jl 96.1% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d487045...7cfb30b. Read the comment docs.

@tkoolen tkoolen merged commit daca170 into master Oct 8, 2018
@tkoolen tkoolen deleted the tk/canonicalize branch October 8, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant