Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #67, sugar for creating Parameters that are updated externally. #84

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

tkoolen
Copy link
Owner

@tkoolen tkoolen commented Sep 25, 2018

CC: @rdeits, @schmrlng, @timholy. How's this?

Also update the readme examples and improve Parameter constructor
docstrings.
@codecov
Copy link

codecov bot commented Sep 25, 2018

Codecov Report

Merging #84 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   97.76%   97.76%   +<.01%     
==========================================
  Files           8        8              
  Lines         492      493       +1     
==========================================
+ Hits          481      482       +1     
  Misses         11       11
Impacted Files Coverage Δ
src/lazyexpression.jl 100% <ø> (ø) ⬆️
src/parameter.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2d750...4dd4027. Read the comment docs.

@schmrlng
Copy link
Contributor

Sure, this looks great. Thanks!

@tkoolen
Copy link
Owner Author

tkoolen commented Sep 26, 2018

OK, merging.

@tkoolen tkoolen merged commit d487045 into master Sep 26, 2018
@timholy
Copy link
Contributor

timholy commented Sep 26, 2018

Yes, this looks quite reasonable, thanks!

@tkoolen tkoolen deleted the tk/parameter-ctors branch September 26, 2018 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants