Adjust SC_OPEN_MAX and SC_STREAM_MAX for macOS 13 (Ventura) and later #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
open_max-darwin-macos13
branch
6 times, most recently
from
fd944b7 to
6b66219
Compare
tklauser
force-pushed
the
open_max-darwin-macos13
branch
from
6b66219 to
d077ee4
Compare
Go started bumping RLIMIT_NOFILE in syscall init() for Go processes but restores the setting for subprocess, see https://go.dev/issue/46279 and https://go.dev/doc/go1.19#runtime. This make TestGetconf fail on systems where sysconf(SC_OPEN_MAX) uses getrlimit(RLIMIT_NOFILE), e.g. on darwin.
tklauser
force-pushed
the
open_max-darwin-macos13
branch
from
d077ee4 to
0d7236e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the implementation in
https://github.com/apple-oss-distributions/Libc/blob/7861c72b1692b65f79c03f21a8a1a8e51e14c843/gen/FreeBSD/sysconf.c#L105