Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback MSRV bump #208

Merged
merged 11 commits into from
Feb 20, 2024
Merged

Rollback MSRV bump #208

merged 11 commits into from
Feb 20, 2024

Conversation

tkaitchuck
Copy link
Owner

Reverts part of the broadening of the scope in #183 to avoid the errors caused by #200 without having to increase the MSRV. This reverts #195
and fixes #207

tkaitchuck and others added 10 commits October 24, 2023 18:14
The following updates are performed:
* update actions/checkout to v4
* replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain
* replace unmaintained actions-rs/cargo by direct invocation of cargo
Signed-off-by: Tom Kaitchuck <[email protected]>
* Bump rust-version to 1.72.0

* Bump rust version in MSRC CI check
…197)

Increase the MSRV presubmit checks to include multiple architectures

Signed-off-by: Tom Kaitchuck <[email protected]>
Merge master into release 0.8 branch
Signed-off-by: Tom Kaitchuck <[email protected]>
Copy link

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this branch works for me with rustc 1.63.

One nit, getting a warning from an unused import, might want to cfg-gate it accordingly:

> cargo +1.63 build
warning: file found to be present in multiple build targets: /Users/USER/workspace/aHash/tests/bench.rs
warning: unused import: `zerocopy::transmute`
 --> src/operations.rs:2:5
  |
2 | use zerocopy::transmute;
  |     ^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: `ahash` (lib) generated 1 warning

It would also be great to add a MSRV check to CI to ensure it will be monitored continuously.

Signed-off-by: Tom Kaitchuck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Significant bump in MSRV from 0.8.7 to 0.8.8
5 participants