Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts tidy is a bug? #51

Closed
ChunMengLu opened this issue Aug 7, 2019 · 3 comments
Closed

opts tidy is a bug? #51

ChunMengLu opened this issue Aug 7, 2019 · 3 comments

Comments

@ChunMengLu
Copy link

var tidy = this.key;

function Limiter(opts) {
  this.id = opts.id;
  this.db = opts.db;
  this.tidy = opts.tidy || false;
  // ... ...
}

emmm,but tidy = this.key !

Limiter.prototype.get = function (fn) {
  var db = this.db;
  var tidy = this.key;
  var duration = this.duration;
  // ... ...
}
@noamshemesh
Copy link
Collaborator

you are right, that means that tidy was always true until now.
I will release a version soon without the ability to set tidy (what will make it always true) and will remove this from the documentation for now.
Thanks

@peng-huang-ch
Copy link
Contributor

I‘m sorry for making such a mistake.
now, the tidy always true, I will fix it as soon as possiable.

@noamshemesh
Copy link
Collaborator

noamshemesh commented Aug 15, 2019

Thanks @penghap

No need to submit a PR, this is a minor issue that I will fix soon.

@peng-huang-ch peng-huang-ch mentioned this issue Aug 15, 2019
noamshemesh added a commit that referenced this issue Aug 16, 2019
noamshemesh added a commit that referenced this issue Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants