WIP resolves #649 switch to a modern test infrastructure#755
Closed
mojavelinux wants to merge 1 commit intotj:masterfrom
Closed
WIP resolves #649 switch to a modern test infrastructure#755mojavelinux wants to merge 1 commit intotj:masterfrom
mojavelinux wants to merge 1 commit intotj:masterfrom
Conversation
Contributor
Author
|
Thoughts? |
Collaborator
|
I think that there is no problem in selecting |
Contributor
Author
|
👍 I will continue adding a few more test cases. I'm sure it will raise some questions. |
Collaborator
|
(Adding link to #649 for easier clicking.) |
Closed
|
I have minor quibbles with ava, but not enough to want to bikeshed about it. I'd say go for it 👍 |
Collaborator
|
I like Jest. The main advantage for Commander is it is much more widely used than Ava, so will be familiar to more people contributing to Commander. The main personal advantage is that Jest is the testing framework I use at work and at home! I'm working on the conversion in #1035 Are you still ok with Jest @abetomo ? |
Collaborator
|
I think Jest is better. |
Collaborator
|
Closing in favour of #1035. Started move to Jest. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will hopefully kick off the migration to a modern test infrastructure. There are still many tests to rewrite. But we first need to decide whether ava is the right choice for this project. Then we can divide and conquer to finish migrating the tests.
The tests are temporarily stored in the test-ava folder until the old tests are cleared out of the way.
Use the following command to run the tests: