Add ability to specify arguments syntax for top-level command#258
Merged
SomeKittens merged 1 commit intotj:masterfrom Mar 19, 2015
Merged
Add ability to specify arguments syntax for top-level command#258SomeKittens merged 1 commit intotj:masterfrom
SomeKittens merged 1 commit intotj:masterfrom
Conversation
Collaborator
|
Could you add some tests for this? |
* index.js: Add arguments method, support top-level command in action.
rrthomas
force-pushed
the
args-for-top-level
branch
from
42bac94 to
fdc3c29
Compare
Contributor
Author
|
Done. |
|
Any chance that this will be merged in the near future? |
Collaborator
|
LGTM. Sorry about the wait. |
SomeKittens
added a commit
that referenced
this pull request
Mar 19, 2015
Add ability to specify arguments syntax for top-level command
Contributor
Author
|
Thanks, @SomeKittens! |
|
Awesome, I really appreciate what you did here :-) The only thing I am missing is an update to the docs: How do I use this? |
Contributor
Author
|
@goloroden: for now, see #257. Please file a new issue for documentation, and I'll do it when I can. |
|
Okay :-) |
Collaborator
|
@thethomaseffect @rrthomas IMO, It would be better that PRs like this should get merged after the document is ready. I am preparing for the next release and find this PR without document. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would fix issue #257.