-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Completed nested command support. #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /** | ||
| * Module dependencies. | ||
| */ | ||
|
|
||
| var program = require('../') | ||
| , should = require('should'); | ||
|
|
||
| program | ||
| .version('0.0.1'); | ||
|
|
||
| var commandContext; | ||
| var optionContext; | ||
|
|
||
| var setup = program.command('setup') | ||
| .description('run setup commands for all envs') | ||
| .action(function(env, options){ | ||
| commandContext = this; | ||
| }); | ||
|
|
||
| program.parse(['node', 'test', 'setup']); | ||
| commandContext._name.should.equal('setup'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| /** | ||
| * Module dependencies. | ||
| */ | ||
|
|
||
| var program = require('../') | ||
| , should = require('should'); | ||
|
|
||
| var commandContext; | ||
|
|
||
| program | ||
| .version('0.0.1') | ||
| .on('--help', function() { | ||
| helpCommand = this._name; | ||
| }); | ||
|
|
||
| var setupCommand = program | ||
| .command('setup') | ||
| .action(function(env, options){ | ||
| commandContext = this; | ||
| }) | ||
| .on('--help', function() { | ||
| helpCommand = this._name; | ||
| }); | ||
|
|
||
| var addCommand = setupCommand | ||
| .command('add') | ||
| .option('--value [value]') | ||
| .action(function() { | ||
| commandContext = this; | ||
| }) | ||
| .on('--help', function() { | ||
| helpCommand = this._name; | ||
| }); | ||
|
|
||
| var remoteCommand = addCommand | ||
| .command('remote') | ||
| .action(function() { | ||
| commandContext = this; | ||
| }) | ||
| .on('--help', function() { | ||
| helpCommand = this._name; | ||
| }); | ||
|
|
||
| program.parse(['node', 'test', 'setup']); | ||
| commandContext._name.should.equal('setup'); | ||
|
|
||
| program.parse(['node', 'test', 'setup', 'add']); | ||
| commandContext._name.should.equal('add'); | ||
|
|
||
| program.parse(['node', 'test', 'setup', 'add', '--value', 'true']); | ||
| commandContext._name.should.equal('add'); | ||
|
|
||
| program.parse(['node', 'test', 'setup', 'add', 'remote']); | ||
| commandContext._name.should.equal('remote'); | ||
|
|
||
| // Make sure we still catch errors with required values for options | ||
| var exceptionOccurred = false; | ||
| var oldProcessExit = process.exit; | ||
| var oldConsoleError = console.error; | ||
| process.exit = function() { exceptionOccurred = true; throw new Error(); }; | ||
| console.error = function() {}; | ||
|
|
||
| try { | ||
| program.parse(['node', 'test', '--help']); | ||
| } catch(ex) { | ||
| } | ||
| helpCommand.should.equal('test'); | ||
|
|
||
| try { | ||
| program.parse(['node', 'test', 'setup', '--help']); | ||
| } catch(ex) { | ||
| } | ||
| helpCommand.should.equal('setup'); | ||
|
|
||
| try { | ||
| program.parse(['node', 'test', 'setup', 'add', '--help']); | ||
| } catch(ex) { | ||
| } | ||
| helpCommand.should.equal('add'); | ||
|
|
||
| try { | ||
| program.parse(['node', 'test', 'setup', 'add', 'remote', '--help']); | ||
| } catch(ex) { | ||
| } | ||
| helpCommand.should.equal('remote'); | ||
|
|
||
| process.exit = oldProcessExit; | ||
| exceptionOccurred.should.be.true; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose for these
try/catchblocks? These are tests, we'd want all exceptions to bubble up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was cribbing from https://github.com/visionmedia/commander.js/blob/master/test/test.options.commands.js#L103. Basically, we hijack process.exit(x) and have it throw an error (which help calls process.exit(0)) https://github.com/visionmedia/commander.js/pull/245/files#diff-48e1e0644a9c6aeb3fee25b9561b1692R60 We are OK with having the program exit (that is what help is supposed to do) but we want to assert that it was actually called (we add a
on('help')above that sets the variable if help is called.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks