Skip to content

Improve negative test #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
+1 −1
Merged

Improve negative test #2428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/command.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,7 @@ Expecting one of '${allowedValues.join("', '")}'`);

const negativeNumberArg = (arg) => {
// return false if not a negative number
if (!/^-\d*\.?\d+(e[+-]?\d+)?$/.test(arg)) return false;
if (!/^-(\d+|\d*\.\d+)(e[+-]?\d+)?$/.test(arg)) return false;
// negative number is ok unless digit used as an option in command hierarchy
return !this._getCommandAndAncestors().some((cmd) =>
cmd.options
Expand Down
Loading