Add getOptionValue and setOptionValue#1521
Merged
shadowspawn merged 7 commits intotj:release/8.xfrom May 18, 2021
Merged
Conversation
shadowspawn
changed the title
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
(Note: this PR was branched from #1520 before that was merged, and first three commits are from that branch and actually already merged.)
Problem
Now we are not storing options as properties on command, there is not a public
way of setting option values. This may become more common with the new hooks.
Solution
Make the existing internal routines public and add tests et al
ChangeLog
.getOptionValue()and.setOptionValue()