Add Command parent property to TypeScript#1475
Merged
shadowspawn merged 1 commit intotj:developfrom Feb 20, 2021
Merged
Conversation
abetomo
approved these changes
Feb 20, 2021
Collaborator
abetomo
left a comment
There was a problem hiding this comment.
Thank you for your quick response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
The
parentproperty is not declared in the TypeScript typings. The common use case for it is accessing the global option values in an action handler, and I have shown this in multiple examples in comments.Related: #1184 #1427 (comment)
Previously accessing
cmd.parentwould not have caused a Typescript error, but the typings are stricter in Commander 7 now we no longer store options values as properties by default (hurrah!). This might lead to requests for other properties to be declared too, but planning to only add them on demand rather than declare everything.Still thinking about providing a higher level way of accessing global options (#1229 #1155) but don't have one yet!
Solution
Declare
parentproperty onCommandobject.ChangeLog
parentproperty to TypeScript definition for Command