Skip to content

Add cjs to list of expected node script extensions #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2021
Merged

Add cjs to list of expected node script extensions #1449

merged 3 commits into from
Jan 30, 2021

Conversation

@shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jan 30, 2021 •
edited
Loading

Pull Request

Problem

Node uses .cjs for specifically CommonJS javascript files, like .mjs for esm. Commander does not check for that extension when considering how to launch external stand-alone subcommands.

Solution

Add .cjs.

ChangeLog

  • Add .cjs to expected script file extensions.

To Do

  • Add tests for file suffixes. We have a test for .ts but not for .mjs or .cjs.

@shadowspawn shadowspawn changed the title Add cjs to list of expected node script extensions [WIP] Add cjs to list of expected node script extensions Jan 30, 2021
@shadowspawn shadowspawn changed the title [WIP] Add cjs to list of expected node script extensions Add cjs to list of expected node script extensions Jan 30, 2021
@shadowspawn shadowspawn marked this pull request as ready for review January 30, 2021 04:57
abetomo
abetomo approved these changes Jan 30, 2021
View reviewed changes
Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Jan 30, 2021
@shadowspawn shadowspawn merged commit a28a89b into tj:develop Jan 30, 2021
@shadowspawn shadowspawn deleted the feature/cjs branch January 30, 2021 10:50
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Feb 15, 2021
This was referenced Mar 8, 2021
Merged
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@TheManager73 TheManager73 mentioned this pull request Aug 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abetomo abetomo abetomo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shadowspawn @abetomo