Allow disabling the built-in help option #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
Collaborator
Author
|
Released in Commander v6.1 |
This was referenced Aug 28, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
People have asked about disabling the built-in help menu, usually to add their own help option and help handling. (This may be used less if it is possible to customise the help directly: #1296)
See: #1225 for collected issues
Solution
Add support for
.helpOption(false)which disables the built-in help option. This is symmetrical with.addHelpCommand(false).Nice simple change in API and README, but lots of small code changes.
ChangeLog
.helpOption(false)(Allow disabling the built-in help option #1325)