Add configuration options to addCommand#1232
Merged
shadowspawn merged 2 commits intotj:developfrom Mar 30, 2020
Merged
Conversation
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This was referenced Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
.addCommand()is missing the configuration options to offer the same control as for commands implemented using action handlers and executables.I dislike variables starting with "no" or "not" as it requires extra thought to process what it means when set to a value especially with double negatives, like
noHelp:false.Solution
.addComand()hiddenas new preferred name fornoHelpexecutableFilevalid only for executable configuration options in TypeScriptChangeLog
.addCommand()noHelptohidden(but not remove old support)