Tidier use of global program with require#1200
Merged
shadowspawn merged 1 commit intotj:developfrom Feb 20, 2020
Merged
Conversation
Collaborator
Author
|
I'll do a prerelease soon to get |
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes to README to make use of exported
programadded in #1195Problem
The export from commander is a combination of a global Command object, and classes, especially Command. Global object exports are somewhat out of fashion these days.
The require examples in the README were all using the global object.
Solution
Use the new
programexport and the destructure syntax to more explicitly import a global Command object,