Skip to content

fix(ts): action can be an async function #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shadowspawn merged 1 commit into from
Feb 2, 2020
Merged

fix(ts): action can be an async function #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion typings/commander-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,14 @@ function increaseVerbosity(v: any, total: number) {
return total + 1;
}

function syncCall() {
console.log("Sync success!");
}

async function asyncCall() {
return;
}

program
.version('0.0.1')
.usage('[options] <file ...>')
Expand Down Expand Up @@ -111,7 +119,11 @@ program

program
.command("name1", "description")
.command("name2", "description", { isDefault:true })
.command("name2", "description", { isDefault:true });

program
.command("name3").action(syncCall)
.command("name4").action(asyncCall);

program
.exitOverride();
Expand Down
2 changes: 1 addition & 1 deletion typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ declare namespace commander {
*
* @returns Command for chaining
*/
action(fn: (...args: any[]) => void): Command;
action(fn: (...args: any[]) => void | Promise<void>): Command;

/**
* Define option with `flags`, `description` and optional
Expand Down