Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 2.x executable subcommand tracking and update dependencies #1059

Merged
merged 4 commits into from
Sep 28, 2019

Conversation

shadowspawn
Copy link
Collaborator

This one is optional. I put together a last update for 2.x before we move onto 4.x.

If you are ok with this PR and a 2.x release @abetomo , I could publish this one.

Copy link
Collaborator

@abetomo abetomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadowspawn shadowspawn merged commit 48b02f0 into tj:release/2.x Sep 28, 2019
@shadowspawn shadowspawn deleted the release/2.x branch September 28, 2019 21:29
@shadowspawn
Copy link
Collaborator Author

Known issue: the CI tests are failing because the new version of eslint requires node 8, but it is only the lint which is failing and the unit tests are passing.

Not planning to fix this unless we need to do more work on 2.x.

@shadowspawn
Copy link
Collaborator Author

Thanks to Checkmarx Application Security Research Team for reporting an issue.

abetomo added a commit to abetomo/commander.js that referenced this pull request Oct 11, 2019
abetomo added a commit to abetomo/commander.js that referenced this pull request Oct 11, 2019
abetomo added a commit to abetomo/commander.js that referenced this pull request Oct 11, 2019
abetomo added a commit that referenced this pull request Oct 11, 2019
@shadowspawn
Copy link
Collaborator Author

This issue was responsibly reported by the Checkmarx Application Security Research Team. It was fixed in v2.20.3 (#1059) and v3.0.2(#1056).

The Checkmarx vulnerability library lists this as: https://devhub.checkmarx.com/cve-details/Cx435a6fda-ca38/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants