Wrap and indent help descriptions for options and commands#1051
Merged
shadowspawn merged 3 commits intotj:developfrom Sep 22, 2019
Merged
Wrap and indent help descriptions for options and commands#1051shadowspawn merged 3 commits intotj:developfrom
shadowspawn merged 3 commits intotj:developfrom
Conversation
Co-authored-by: Ephigenia <love@ephigenia.de>
Collaborator
Author
|
FYI: @Ephigenia |
Collaborator
Author
|
No rush @abetomo, I requested review here accidentally. Thanks for other reviews already today! |
abetomo
reviewed
Sep 21, 2019
| * | ||
| * @param {String} str | ||
| * @param {Number} width | ||
| * @param {Number} indent |
Collaborator
There was a problem hiding this comment.
The document parameter is missing minWidth.
Collaborator
Author
There was a problem hiding this comment.
Prompted by this, I moved minWidth to an internal detail.
abetomo
reviewed
Sep 21, 2019
index.js
Outdated
| function wrap(str, width, indent) { | ||
| var regex = new RegExp('.{1,' + (width - 1) + '}([\\s\u200B]|$)|[^\\s\u200B]+?([\\s\u200B]|$)', 'g'); | ||
| var lines = str.match(regex) || []; | ||
| var result = lines.map(function(line, i) { |
Collaborator
There was a problem hiding this comment.
How about returning directly without assigning to a variable?
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
This was referenced Mar 6, 2020
This was referenced Mar 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish off #956 with Jest tests and last fixes. See #956 for description and discussion.
(I realised when adding tests for this I have never tried the somewhat undocumented argsDescription parameter to
.description, and not currently being tested here.)