Keep command out of program.args and add unknown to .action params

[shadowspawn]

This reimplements #1030 after the move to Jest. See #1030 for description and discussion.

[abetomo]

Thank you.

[xPaw]

This PR now makes it impossible to detect whether any command has run, like the example in: #7 (comment)

We want to print help when no command has run, and it doesn't really seem to be possible (process just exists without printing anything). Checking process.argv.length is not really a good option either.

And on top of that command:* is not triggered either if you pass no command.

[shadowspawn]

@xPaw
Sorry you hit issues.

This PR does change the behaviour in an area that people have written code based on undocumented details of the previous behaviour, so will cause some breakages. Hopefully we can work out a more robust way to achieve the same behaviours, and where appropriate add migration steps to the Release Notes.

I test process.argv.length in my own CLI program for the specific case that user ran my command with no arguments:

// Show help if no command specified.
if (process.argv.length === 2) {
  program.help();
}

Please open a new issue with an example of what you are trying to do and some example code.

[xPaw]

process.argv.length is not really an elegant solution.

Issue was already made in 2011 about this: #7, you could just re-open that.

[shadowspawn]

#7 was closed, with some up-voted example code supplied which tests program.args rather than process.argv: #7 (comment)

Does that work for your case?

[xPaw]

This PR specifically "broke" testing program.args as it not longer pushes the found command to it. That's what I did before.

My current "fix" was to use program.rawArgs

thelounge/thelounge@e09599a#diff-25f700bb76bbf957569bd288fbf7d328L63-R63

[shadowspawn]

Ok, I see the problem. Not sure about best solution yet, but that is reasonable.

[shadowspawn]

I have added a migration tip to the Release Notes, but it might be an issue that needs a better solution. The detection of unrecognised commands and missing commands when using action handlers is a bit fragile.