Conversation
|
Nice! I will research a bit about Github Actions before reviewing. (There will likely be some minor code changes to get current tests running and passing on Windows: #916 ) |
|
3.0.1 is out, so keen to give this a go! (Did you sign up for the beta?) Thanks @abetomo. I was thinking of the Azure PR we got a while ago but I like this better. |
shadowspawn
left a comment
There was a problem hiding this comment.
Might want to call it tests.yml?
|
I'll let you do the merge @abetomo. Keen to see what happens. 🙂 |
585b33e to
dcbd62f
Compare
dcbd62f to
977db09
Compare
|
Renamed the configuration file, and fixed the problem with the settings. This was the result for my repository. This repository is also valid, so it will work if merged. |
|
https://github.com/tj/commander.js/runs/207817593 |
|
Nice! How do you see the runs? (When I go to Actions I just see templates, but I can follow your link and see that run.) |
|
Probably, you can see it from the 'Actions' tab once it has been merged with master. |
|
I have signed up for the Actions beta, I might be able to see more when accepted. It does not look like the test are running on Windows, but I was not sure why on first look. (Woop woop! Thanks.) |
|
I got added to the beta program, and can see the past workflow runs now. I am still suspicious whether the Windows test are running but clearly they are meant to. Looking forward to merging with the Jest branch. Exciting! |

You can also test on Windows.
Pull Request
Problem
We were not using Windows CI.
Solution
Use GitHub Actions to test on Windows.
ChangeLog