fix: update input warning #1870

jackton1 · 2024-01-17T08:28:18Z

No description provided.

src/main.ts

src/utils.ts

Co-authored-by: tj-actions[bot] <[email protected]>

- Addition of `ACTION_INPUT_DEFAULTS` object in `constant.ts` including default settings. - Made changes in `utils.ts` replacing `actionInputs` references with the newly added `ACTION_INPUT_DEFAULTS`.

- Removed imports for the `fs` module and `path` from the `utils.test.ts` file - Deleted the `actionPath` argument from the `warnUnsupportedRESTAPIInputs` function in `utils.test.ts` - All tests related to YAML errors in the action file have been removed from `utils.test.ts` - Removed the `UNSUPPORTED_REST_API_INPUTS` constant from the `constant.ts` file and replaced it with a `Partial` type within the `UNSUPPORTED_REST_API_INPUTS` export - The file `utils.ts` has been updated to reflect the changes in `constant.ts`. It now iterates over `Object.keys(UNSUPPORTED_REST_API_INPUTS)`, substitutes `UNSUPPORTED_REST_API_INPUTS` for `ACTION_INPUT_DEFAULTS`, and uses type casting in condition checking.

- Remove the conditional checking for `GITHUB_ACTION_PATH` before calling `warnUnsupportedRESTAPIInputs` - Change in procedure for getting changed files from the REST API.

…function - Change the way key is referenced in the `warnUnsupportedRESTAPIInputs` function in `utils.ts` to use `snakeCase` only at the point of warning message generation.

- Remove the `sha` parameter from the `.github/workflows/multi-job-test.yml` file - Add an expectation to check if `coreWarningSpy` is called once in `utils.test.ts`

…542) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tj-actions/changed-files](https://github.com/tj-actions/changed-files) | action | major | `v41` -> `v42` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>tj-actions/changed-files (tj-actions/changed-files)</summary> ### [`v42`](https://github.com/tj-actions/changed-files/releases/tag/v42) [Compare Source](https://github.com/tj-actions/changed-files/compare/v41...v42) ##### Changes in v42.0.0 ##### 🔥🔥 BREAKING CHANGE 🔥🔥 - Input file patterns that end with a `/` would now match all sub-files within the directory without requiring you to specify the globstar pattern. ##### ```yaml ... - name: Get changed files id: changed-files uses: tj-actions/changed-files@v42 with: files: 'dir/' # Would also be the same as dir/** ``` ##### What's Changed - Upgraded to v41.1.2 by [@tj-actions-bot](https://github.com/tj-actions-bot) in [https://github.com/tj-actions/changed-files/pull/1869](https://github.com/tj-actions/changed-files/pull/1869) - chore(deps): update dependency prettier to v3.2.4 by [@renovate](https://github.com/renovate) in [https://github.com/tj-actions/changed-files/pull/1871](https://github.com/tj-actions/changed-files/pull/1871) - fix: update input warning by [@jackton1](https://github.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1870](https://github.com/tj-actions/changed-files/pull/1870) - rename: unsupported REST API inputs constant name by [@jackton1](https://github.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1872](https://github.com/tj-actions/changed-files/pull/1872) - feat: add support for include/exclude all nested files when a directory is specified and ends with a slash by [@jackton1](https://github.com/jackton1) in [https://github.com/tj-actions/changed-files/pull/1873](https://github.com/tj-actions/changed-files/pull/1873) **Full Changelog**: tj-actions/changed-files@v41...v42.0.0 *** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

jackton1 added 2 commits January 17, 2024 01:28

fix: update input warning

aacdc82

Update utils.ts

db20d41

tj-actions-bot reviewed Jan 17, 2024

View reviewed changes

src/main.ts Outdated Show resolved Hide resolved

src/utils.ts Outdated Show resolved Hide resolved

src/utils.ts Outdated Show resolved Hide resolved

src/utils.ts Outdated Show resolved Hide resolved

jackton1 and others added 15 commits January 17, 2024 01:46

Apply suggestions from code review

c28eedd

Co-authored-by: tj-actions[bot] <[email protected]>

Update utils.ts

375be20

chore(deps): update dependency prettier to v3.2.4

79b060d

refactor: refactor action inputs to use default settings

8a8e4b7

- Addition of `ACTION_INPUT_DEFAULTS` object in `constant.ts` including default settings. - Made changes in `utils.ts` replacing `actionInputs` references with the newly added `ACTION_INPUT_DEFAULTS`.

Merge 59d9755 into 79b060d

1839724

Added missing changes and modified dist assets.

c2907d5

Update multi-job-test.yml

89fe46d

refactor: refactor GitHub actions and API handling

b8d749c

- Remove the conditional checking for `GITHUB_ACTION_PATH` before calling `warnUnsupportedRESTAPIInputs` - Change in procedure for getting changed files from the REST API.

Merge b8d749c into 79b060d

6f76336

Added missing changes and modified dist assets.

78bbe66

refactor: refactor key referencing in warnUnsupportedRESTAPIInputs …

08316e3

…function - Change the way key is referenced in the `warnUnsupportedRESTAPIInputs` function in `utils.ts` to use `snakeCase` only at the point of warning message generation.

Merge 08316e3 into 79b060d

990ef65

Added missing changes and modified dist assets.

16ab734

ci: "Refactor testing workflow and improve assertions"

19bdaea

- Remove the `sha` parameter from the `.github/workflows/multi-job-test.yml` file - Add an expectation to check if `coreWarningSpy` is called once in `utils.test.ts`

jackton1 merged commit 6c9dcea into main Jan 18, 2024
114 checks passed

jackton1 deleted the fix/update-input-warning branch January 18, 2024 03:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update input warning #1870

fix: update input warning #1870

jackton1 commented Jan 17, 2024

fix: update input warning #1870

fix: update input warning #1870

Conversation

jackton1 commented Jan 17, 2024