Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript 최신버전 적용 및 타입에러 수정 #2435

Merged
merged 8 commits into from
Feb 28, 2023
Merged

Typescript 최신버전 적용 및 타입에러 수정 #2435

merged 8 commits into from
Feb 28, 2023

Conversation

choisohyun
Copy link
Contributor

PR 설명

변경 내역

체크리스트

스크린샷 & URL

@choisohyun choisohyun self-assigned this Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Base: 31.54% // Head: 31.54% // No change to project coverage 👍

Coverage data is based on head (c3c6136) compared to base (307786c).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   31.54%   31.54%           
=======================================
  Files         763      763           
  Lines       10824    10824           
  Branches     3425     3425           
=======================================
  Hits         3414     3414           
  Misses       7129     7129           
  Partials      281      281
Impacted Files Coverage Δ
packages/ad-banners/src/content-details-banner.tsx 0.00% <ø> (ø)
packages/ad-banners/src/list-top-banners.tsx 0.00% <ø> (ø)
...kages/core-elements/src/elements/tabs/tab-base.tsx 13.79% <ø> (ø)
...ages/core-elements/src/elements/tabs/tab-panel.tsx 60.00% <ø> (ø)
...-tracking-context/with-event-tracking-provider.tsx 40.00% <0.00%> (ø)
...ages/router/src/href-to-props/use-href-to-props.ts 89.39% <0.00%> (ø)
packages/web-storage/src/storage.ts 0.00% <0.00%> (ø)
packages/web-storage/src/utils.ts 0.00% <0.00%> (ø)
packages/modals/src/login-cta-modal.tsx 79.41% <50.00%> (ø)
packages/scrap-button/src/scrap-button-mask.tsx 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@choisohyun choisohyun added this to the v12.10.1 milestone Feb 27, 2023
@choisohyun choisohyun marked this pull request as ready for review February 27, 2023 07:25
@choisohyun choisohyun requested a review from a team as a code owner February 27, 2023 07:25
pgs787
pgs787 previously approved these changes Feb 27, 2023
View reviewed changes
YWTechIT
YWTechIT previously approved these changes Feb 27, 2023
View reviewed changes
drakang4
drakang4 reviewed Feb 27, 2023
View reviewed changes
packages/ad-banners/src/content-details-banner.tsx Outdated
requestIdleCallback?(callback: () => void, timeout?: number): number
cancelIdleCallback?(handle: number): void
requestIdleCallback(callback: () => void, timeout?: number): number
cancelIdleCallback(handle: number): void
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 lib/dom.d.ts에 정의 안되어 있나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정의되어 있습니다! 옵셔널 안지우니까 요런 에러로 나오더라구요 TS2386: Overload signatures must all be optional or required.
음 근데 원래 타입 보니까 required인걸 optional로 쓰려고 그런것 같군요
이거 우선 ts ignore 걸어놓는거로 바꾸겠습니다..!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c5a1076 수정했습니다 🙇🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declare global도 아예 지우는게 좋을 것 같아요.
dom.d.ts에 requestIdleCallback, cancelIdleCallback 정의 추가된 게 타입스크립트 4.4 버전이라서 없던 시절에 직접 정의해서 쓰던 것 같습니다.

microsoft/TypeScript-DOM-lib-generator#1029 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하 정의가 원래 있던 게 아니군요! 수정했습니다~! c3c6136

@choisohyun choisohyun dismissed stale reviews from YWTechIT and pgs787 via c5a1076 February 27, 2023 08:51
@jaehyeon48 jaehyeon48 modified the milestones: v12.10.1, v12.11.0 Feb 28, 2023
@choisohyun choisohyun merged commit e8391c4 into main Feb 28, 2023
@choisohyun choisohyun deleted the fix/typescript branch February 28, 2023 01:35
@jaehyeon48 jaehyeon48 mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drakang4 drakang4 drakang4 approved these changes

@zhsks528 zhsks528 zhsks528 approved these changes

@jaehyeon48 jaehyeon48 jaehyeon48 approved these changes

@inbeom inbeom Awaiting requested review from inbeom inbeom is a code owner automatically assigned from titicacadev/frontend

@YWTechIT YWTechIT Awaiting requested review from YWTechIT

@pgs787 pgs787 Awaiting requested review from pgs787

Assignees

@choisohyun choisohyun

Labels
None yet
Projects
None yet
Milestone
v12.11.0
Development

Successfully merging this pull request may close these issues.

Typescript 최신버전 적용하기
6 participants
@choisohyun @drakang4 @zhsks528 @pgs787 @jaehyeon48 @YWTechIT