Minor update and improvements in README.md #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 update documentation links as the old one was returning 404 🔗 add links for more devices 📄 clarify where to get the default FRITZ!Box user
|
Awesome, thank you! Anything else you want to add/change? Asking because you opened the PR as a draft… |
|
Hi @tisba For the PR specifically, I have a few more things coming up (more commits). Nothing major thought. I'm also debugging an issue (might be a user issue) but I'll open a separate issue and eventually a PR if I'm able to produce a fix. Thanks a lot though for noticing this PR 🌿. |
…self-signed TLS certificate (which is typical when the user has never uploaded a certificate before)
|
@tisba This is ready to review. |
…is an option to provide the password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 update documentation links as the old one was returning 404 🔗 add links for more devices
📄 clarify where to get the default FRITZ!Box user
🌿 add missing
--passwordgeneral option andFRITZTLS_ADMIN_PASSenvironment variable🌿 add missing
--manualthat's required when specifying locally stored TLS material📄 small clarification about --insecure in the context of a default self-signed TLS certificate (which is typical when the user has never uploaded a certificate before)
🌿 document
--acme-serverand--version🐛 fix error messages (x2) referencing
--privatekeyinstead of--key📄 update how to install
fritz-tls