Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configured DevContainer for Python Client; Fixed HF Unittest; Integrated Unittests into VSCode; Quality of Life #660

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Configured DevContainer for Python Client; Fixed HF Unittest; Integrated Unittests into VSCode; Quality of Life #660

merged 10 commits into from
Sep 3, 2024

Conversation

TheMrSheldon
Copy link
Member

This PR provides some general fixes and improvements to the repo and the VSCode integration:

  • Updated the dev container config for developing the Python Client (including Docker integration with the docker host)
  • Moved all dev container related stuff (especially .devfiles) into .devcontainer to clean up the project root
  • Integrated python unittests into VSCode (this also required configuring a multiroot workspace)
  • Consolidated all unittest actions into test.yaml
  • Removed django static files (unused and added untested paths)
  • Removed _default_hf_home_in_tira_host

@TheMrSheldon TheMrSheldon added enhancement New feature or request python Pull requests that update Python code labels Sep 3, 2024
@TheMrSheldon TheMrSheldon self-assigned this Sep 3, 2024
mam10eks
mam10eks approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@mam10eks mam10eks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks!

@TheMrSheldon TheMrSheldon merged commit fb66cc7 into development Sep 3, 2024
12 of 14 checks passed
@TheMrSheldon TheMrSheldon deleted the vscode_test_conf branch September 3, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mam10eks mam10eks mam10eks approved these changes

Assignees

@TheMrSheldon TheMrSheldon

Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMrSheldon @mam10eks