Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused endpoints #656

Draft
wants to merge 24 commits into
base: development
Choose a base branch
from
Draft

Conversation

TheMrSheldon
Copy link
Member

No description provided.

@TheMrSheldon TheMrSheldon changed the base branch from main to development July 30, 2024 16:09
@TheMrSheldon TheMrSheldon added enhancement New feature or request python Pull requests that update Python code labels Jul 30, 2024
@TheMrSheldon TheMrSheldon marked this pull request as ready for review August 1, 2024 07:47
@TheMrSheldon TheMrSheldon self-assigned this Aug 1, 2024
@TheMrSheldon TheMrSheldon requested a review from mam10eks August 1, 2024 07:47
@TheMrSheldon TheMrSheldon added this to the ECIR Tutorial 2025 milestone Aug 1, 2024
Copy link
Member

@mam10eks mam10eks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are indeed some good catches that we now can remove:)
Most of the discussion is in a private discourse chat, above I mentioned a few methods that I would like to keep, if we keep them this is ready to go :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the organizer list and add organizer endpoints, as they are conceptually valuable, it can be that they are not embedded in the vuetify UI yet (as this is used not too often) but I then would prefer to incorporate this into the UI soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the all registrations endpoint. If I recall correctly, this should be used in the UI? Maybe this method is duplicated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, the parse_all_runs_of_vm is not used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wpuld like to keep the last four methods, as they are conceptually important, but maybe not yet connected to the new vuetify UI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep all methods here besides the get host list amd get ova list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to keep this method, as tgis is conceptually important

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to keep this, maybe not connected to the new UI, but still valuable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some of the things that I would like to keep, mentioned above :)

@TheMrSheldon TheMrSheldon marked this pull request as draft August 1, 2024 13:47
@TheMrSheldon
Copy link
Member Author

Deferred for now since it probably makes more sense to wait for the mentioned endpoints to have their counterparts implemented in the new REST-API:

  • tira-admin/add-organizer/<str:organizer_id>
  • tira-admin/edit-organizer/<str:organizer_id>
  • tira-admin/create-group/<str:vm_id>
  • tira-admin/import-irds-dataset/<str:task_id>
  • api/organizer-list
  • api/organizer/<str:organizer_id>
  • tira-admin/export-participants
  • api/evaluation/<str:vm_id>/<str:run_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants