This repository was archived by the owner on Dec 16, 2022. It is now read-only.
slack merge upstream 2017 08 21#34
Merged
demmer merged 3 commits intoslack-new-masterfrom Aug 22, 2017
Merged
Conversation
For both vttablet and vtgate, add options to the grpc.Dial call site that pass through the max message size option and thereby override the 4MB default.
Cherry-picked and fixed conflicts from afe78be.
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This branch contains an updated slack fork for vitess in a way that syncs us back with upstream/master and then applies three slack-specific patches that we still need to run with.
This PR is based off the
slack-new-masterbranch. Once approved, I'll merge this PR into that branch, rename our existing master branch toslack-old-master-20170821, and force-push the mergedslack-new-masteras our new master branch.Details
To prepare the branch I looked through our history and found the earliest merge point.
From that I created two new tags:
The content of these two tags / commits are equivalent.
I then created a
slack-new-masterbranch off of the latest upstream/master (8188623), and I created a tag with slack-vitess-082117r0-upstream at this merge point.Then I went through all the slack-specific commits since our latest sync:
Of these I cherry-picked three into this branch:
For e07891a, I actually cherry-picked from my updated upstream branch to fix conflicts.
For afe78be there were a number of conflicts that I reconciled manually.