Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Fix for travis ci#29

Merged
rafael merged 2 commits intomasterfrom
slack/fix-for-travis
Aug 3, 2017
Merged

Fix for travis ci#29
rafael merged 2 commits intomasterfrom
slack/fix-for-travis

Conversation

@rafael
Copy link
Copy Markdown

@rafael rafael commented Aug 2, 2017

  • Set go_import_path so forks of the project can benefit from Travis CI. Without
    this change there are some assumptions in the bootstrap script and also in the
    import of packages that won't be hold in a fork of the project and the tests
    will break.
  • go_import_path feature from travis solves this problem.

Rafael Chacon and others added 2 commits August 2, 2017 16:40
* Set go_import_path so forks of the project can benefit from Travis CI. Without
this change there are some assumptions in the bootstrap script and also in the
import of packages that won't be hold in a fork of the project and the tests
will break.
Travis CI is in the process of changing all images from Precise to Trusty.

See their announcement: https://blog.travis-ci.com/2017-07-11-trusty-as-default-linux-is-coming

This would break how we install our dependencies.

Note that we're using the Container based infrastructure (sudo: false). They plan to get rid of this combination (Precise + sudo: false) by Sep 5. Before that, we should try "sudo: required" or do the planned longterm change to run the tests within Docker images.
Copy link
Copy Markdown

@inexplicable inexplicable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@demmer
Copy link
Copy Markdown
Collaborator

demmer commented Aug 3, 2017

Woot woot. Nice!

@rafael rafael merged commit 77ab678 into master Aug 3, 2017
@rafael rafael deleted the slack/fix-for-travis branch August 3, 2017 00:22
rafael pushed a commit that referenced this pull request Dec 11, 2019
* Converted sharded test from py to go

Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
rafael pushed a commit that referenced this pull request Dec 11, 2019
* Converted sharded test from py to go

Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Signed-off-by: Arindam Nayak <arindam.nayak@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants