Slack vitess 9 2021.05.18r6

.github/workflows/check_formatting.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Check Formatting
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/check_make_parser.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Check Make Parser
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/check_make_visitor.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Check Make Visitor
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/cluster_endtoend.yml

@@ -3,7 +3,7 @@ on: [push, pull_request]
 jobs:
 
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     strategy:
       matrix:
         name: [11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 26, 27]

.github/workflows/cluster_endtoend_upgrade.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Run endtoend tests on Cluster (upgrade)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     steps:
     - name: Set up Go

.github/workflows/cluster_initial_sharding_multi.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: cluster initial sharding multi
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/create_release.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   build:
     name: Create Release
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/docker_test_1.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Docker Test 1
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     steps:
 
@@ -18,4 +18,4 @@ jobs:
 
     - name: Run tests which require docker - 1
       run: |
-        go run test.go -docker=true --follow -shard 10
+        go run test.go -docker=true --follow -shard 10

.github/workflows/docker_test_2.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Docker Test 2
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     steps:
 
@@ -18,4 +18,4 @@ jobs:
 
     - name: Run tests which require docker - 2
       run: |
-        go run test.go -docker=true --follow -shard 25
+        go run test.go -docker=true --follow -shard 25

.github/workflows/docker_test_3.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Docker Test 3
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     steps:
 

.github/workflows/e2e_race.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: End-to-End Test (Race)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/endtoend.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: End-to-End Test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/ensure_bootstrap_updated.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Check Bootstrap Updated
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

.github/workflows/golangci-linter.yml

@@ -3,7 +3,7 @@ on: [push, pull_request]
 jobs:
   build:
     name: Build
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
       - name: Set up Go 1.15
         uses: actions/setup-go@v1

.github/workflows/sonar_analysis.yml

@@ -6,7 +6,7 @@ on:
 jobs:
 
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
 
     steps:
       - name: Set up Go

.github/workflows/unit.yml

@@ -3,7 +3,7 @@ on: [push, pull_request]
 jobs:
 
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     strategy:
       matrix:
         name: [percona56, mysql57, mysql80, mariadb101, mariadb102, mariadb103]

.github/workflows/unit_race.yml

@@ -4,7 +4,7 @@ jobs:
 
   build:
     name: Unit Test (Race)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
 
     - name: Set up Go

doc/releasenotes/9_0_0_release_notes.md

@@ -7,6 +7,9 @@ The following PRs made changes to behaviors that clients might rely on. They sho
 
 Vitess 9.0 is not compatible with the previous release of the Vitess Kubernetes Operator (2.2.0). A new version of the Operator (2.3.0) is available that is compatible.
 
+## Known Issue(s)
+* VReplication errors when a fixed-length binary column is used as the sharding key #8080
+
 ## Bugs Fixed
 
 ### VTGate / MySQL compatibility

doc/releasenotes/9_0_1_release_notes.md

@@ -0,0 +1,38 @@
+This release complies with VEP-3 which removes the upgrade order requirement. Components can be upgraded in any order. It is recommended that the upgrade order should still be followed if possible, except to canary test the new version of VTGate before upgrading the rest of the components.
+
+## Bug fixes
+### Cluster management
+ * Backport: Respect -disable_active_reparents in backup/restore #8063
+### Other
+ * [9.0] fix regression - should be able to plan subquery on top of subquery #7683
+### Query Serving
+ * [9.0] Fix for reserved connection usage with transaction #7666
+ * [9.0] Fix MySQL Workbench failure on login with `select current_user()` #7706
+ * [9.0] make sure to handle subqueries on top of subqueries #7776
+ * [9.0] make sure to not log sensitive information #7778
+ * [9.0] ddl bypass planner #8035
+ * [9.0] Memory Sort to close the goroutines when callback returns error #8040
+ * [9.0] Fix bug with reserved connections to stale tablets #8041
+ * [9.0] Fix for Query Serving when Toposerver is Down #8046
+ * ignore the error and log as warn if not able to validate the current system settings value #8062
+### VReplication
+ * VReplication: fix vreplication timing metrics #8060
+ * VReplication: Pad binlog values for binary() columns to match the value returned by mysql selects #8061
+## Documentation
+### Other
+ * 9.0.0 Release Notes #7384
+## Other
+### Build/CI
+ * Fix Dockerfiles for vtexplain and vtctlclient #7418
+### Query Serving
+ * Fix table parsing on VSchema generation #7511
+ * [9.0] Show anywhere plan fix to consider default keyspace #7530
+ * [9.0] Reset Session for Reserved Connection when the connection id is not found #7544
+ * Healthcheck: update healthy tablets correctly when a stream returns an error or times out #7732
+### VReplication
+ * MoveTables: Refresh SrvVSchema and source tablets on completion #8059
+
+
+The release includes 43 commits (excluding merges)
+Thanks to all our contributors: @askdba, @deepthi, @dyv, @harshit-gangal, @rafael, @rohit-nayak-ps, @shlomi-noach, @systay
+

go/test/endtoend/cluster/cluster_process.go

@@ -56,6 +56,7 @@ type LocalProcessCluster struct {
 	Cell               string
 	BaseTabletUID      int
 	Hostname           string
+	TopoFlavor         string
 	TopoPort           int
 	TmpDirectory       string
 	OriginalVTDATAROOT string
@@ -173,6 +174,8 @@ func (cluster *LocalProcessCluster) StartTopo() (err error) {
 	if cluster.Cell == "" {
 		cluster.Cell = DefaultCell
 	}
+
+	topoFlavor = cluster.TopoFlavorString()
 	cluster.TopoPort = cluster.GetAndReservePort()
 	cluster.TmpDirectory = path.Join(os.Getenv("VTDATAROOT"), fmt.Sprintf("/tmp_%d", cluster.GetAndReservePort()))
 	cluster.TopoProcess = *TopoProcessInstance(cluster.TopoPort, cluster.GetAndReservePort(), cluster.Hostname, *topoFlavor, "global")
@@ -758,9 +761,13 @@ func (cluster *LocalProcessCluster) StartVttablet(tablet *Vttablet, servingStatu
 	return tablet.VttabletProcess.Setup()
 }
 
-//func (cluster *LocalProcessCluster) NewOrcInstance() OrchestratorProcess {
-//
-//}
+// TopoFlavorString returns the topo flavor
+func (cluster *LocalProcessCluster) TopoFlavorString() *string {
+	if cluster.TopoFlavor != "" {
+		return &cluster.TopoFlavor
+	}
+	return topoFlavor
+}
 
 func getCoveragePath(fileName string) string {
 	covDir := os.Getenv("COV_DIR")

go/test/endtoend/cluster/topo_process.go

@@ -230,7 +230,7 @@ func (topo *TopoProcess) TearDown(Cell string, originalVtRoot string, currentRoo
 		// Attempt graceful shutdown with SIGTERM first
 		_ = topo.proc.Process.Signal(syscall.SIGTERM)
 
-		if !*keepData {
+		if !(*keepData || keepdata) {
 			_ = os.RemoveAll(topo.DataDirectory)
 			_ = os.RemoveAll(currentRoot)
 		}