This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Vitess v8 VTctld custom branch + sizes-only#201
Merged
setassociative merged 3 commits intoslack-vitess-8-2021.03.03r0.vtctldfrom Mar 17, 2021
Merged
Conversation
Add option to GetSchema to only send the row count and data length over the wire
ajm188
suggested changes
Mar 17, 2021
ajm188
left a comment
There was a problem hiding this comment.
actual guts of the GetSchema look good, but there's an issue with the conflict resolution that needs to be fixed first!
go/vt/vtctl/vtctl.go
Outdated
| "vitess.io/vitess/go/vt/wrangler" | ||
|
|
||
| replicationdatapb "vitess.io/vitess/go/vt/proto/replicationdata" | ||
| tabletmanagerdatapb "vitess.io/vitess/go/vt/proto/tabletmanagerdata" |
There was a problem hiding this comment.
This line is unused (it was, before you could pass TableSizesOnly directly to the rpc), and probably will cause go build to not succeed
Author
There was a problem hiding this comment.
already go it but not before you saw :shamebell:
Signed-off-by: Richard Bailey <rbailey@slack-corp.com>
ajm188
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were merge conflicts here, would appreciate extra eyes.
Two items of note
1️⃣ the following diff no longer seemed relevant given that the grpc interface had been evolved to support sizes only as a first class flag
2️⃣ The other call out is. that the incoming change wanted to
return printJSON(wr.Logger(), resp.Schema)as the return type which diverged from upstream's mainline so I believe this is the render bug we fixed previously.