This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Cherry pick changes into our build#133
Merged
setassociative merged 4 commits intoslack-vitess-2019.04.02.r1from Jun 5, 2019
Merged
Cherry pick changes into our build#133setassociative merged 4 commits intoslack-vitess-2019.04.02.r1from
setassociative merged 4 commits intoslack-vitess-2019.04.02.r1from
Conversation
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Original Message: The previous (untested) implementation turned out to be in the wrong place in the TabletServer execution tier and did not properly log the actual statements being executed. Implement this the right way by returning the statements that were really executed out from the TxPool, then using those to determine whether or not to log the statement. Original PR: vitessio#4827
The deprecated `unused` command has been removed from the source repository, so this now fails. We no longer use `unused` so we can just drop the line that tries to install it. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forks our 2019-04-02 build and "cherry picks" in the following changes:
I squashed commits 2 and 3 each into a single commit on this branch. Item 2 did not apply cleanly so I had to manually resolve merge conflicts.
Once this merge is approved we will reset our master branch to point here and tag the old master branch so that it's not lost should we need to recover that state:
When it's time to sync back up with upstream we'll revert the 4 comments above and then merge vitessio/vitess master.