Skip to content
This repository was archived by the owner on Dec 16, 2022. It is now read-only.

Upgrade Java to 8#117

Closed
ys8 wants to merge 1 commit intomasterfrom
java8
Closed

Upgrade Java to 8#117
ys8 wants to merge 1 commit intomasterfrom
java8

Conversation

@ys8
Copy link
Copy Markdown

@ys8 ys8 commented Nov 29, 2018

The project already depends on Guava 26.0-jre, which reuqires Java 8. Without this change, the project doesn't even compile in IntelliJ.

The project already depends on Guava 26.0-jre, which reuqires Java 8. Without this change, the project doesn't even compile in IntelliJ.
@ys8 ys8 requested review from demmer and rafael November 29, 2018 22:14
@rafael
Copy link
Copy Markdown

rafael commented Nov 29, 2018

@ys8 could you open this PR upstream?

@ys8
Copy link
Copy Markdown
Author

ys8 commented Nov 29, 2018

Sure. I have other fixes following this PR including

vitessio#4366

and another fix to allow vtgate discovery through consul-template. Should I do all those work in upstream? @demmer asked me to push those fixes to this repo. I'm a newbie to this process, so would appreciate your guidance...

@demmer
Copy link
Copy Markdown
Collaborator

demmer commented Nov 29, 2018

Sorry I didn’t clarify... what we usually do is open a pr here referencing the upstream master.

Then periodically we sync upstream to this master branch for internal deploys.

Many of us do this by having two remotes in our local git environment.

@rafael
Copy link
Copy Markdown

rafael commented Nov 29, 2018

@ys8 - That is correct. We try to keep in sync our fork with upstream, so unless we have some specific reasons we do all our work there.

We have diverged in the past when we needed some changes in an urgent way and we couldn't get them fast enough in upstream. However, this was a temporary and eventually it converged.

@ys8
Copy link
Copy Markdown
Author

ys8 commented Nov 30, 2018

With @rafael 's help, finally opened a PR hopefully in a correct way.

vitessio#4405

For some reasons, it didn't let me edit the reviewers to include @demmer.

@ys8 ys8 closed this Nov 30, 2018
@ys8 ys8 deleted the java8 branch November 30, 2018 01:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants