INT-3303: Update Vue integration tests to use BDD style. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update imports
kemister85
changed the title
update cleanupTinymce to cleanupGlobalTinymce to be more specific. fix spacing between tests. add afterEach to context function.
kemister85
requested review from
spocke,
TheSpyder,
ltrouton,
a team,
jscasca and
tiny-ben-tran
and removed request for
a team
|
Special thanks to @tiny-ben-tran for his time/guidance and assistance in helping me with this PR. |
tiny-ben-tran
approved these changes
Sep 18, 2024
Co-authored-by: tiny-ben-tran <[email protected]>
Co-authored-by: tiny-ben-tran <[email protected]>
Removed Waiter from tests. Wrapped various func into beforeEach() to improve readability.
MitchC1999
approved these changes
Oct 21, 2024
kimwoodfield
approved these changes
Oct 21, 2024
ArvinJ-H
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INT-3303
Changes:
fixed existing console error in Storybook for
Editor.storiesas it was set to an array, but expected string.renamed
cRendertopRenderand updated to usePromise.removed
Chain.opfrom all tests.moved
cleanupTinymceto alien/TestHelper.ts and renamed tocleanupGlobalTinymceto be clearer.created
VAILID_API_KEYvariable to use string interpolation for replacingapi-key="a-fake-api-key".converted all tests to use
describe, itconventions.updated InitTest.ts to iterate over Arr.each to isolate each test run for editor major versions.
Test
yarn buildTest
yarn storybookTest
yarn test-manual