fix: set correct workerId in runtime: 'child_process'#81
fix: set correct workerId in runtime: 'child_process'#81Aslemammad merged 1 commit intotinylibs:mainfrom
workerId in runtime: 'child_process'#81Conversation
|
I couldn't think of a better way to test the correct |
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Impressive how fast you were able to set up a PR. 🚀
@Aslemammad this PR can be considered as semver patch. The process.__tinypool_state__.workerId was always supposed to be Tinypool's workerId and not the process.id as it was set.
workerId in runtime: 'child_process'
|
@AriPerkkio @alisd23 Thank you so much for the effort folks! |
|
Thanks both for the help and getting this through so quick! 👍 |
|
Final thing, @Aslemammad when can we expect a release? Looks like releases are done manually is that right? |
Yea sure, I'm just going to give an access to @AriPerkkio so he can releases. |
|
Thanks! 🙌 I'll do release tomorrow and do some testing with Vitest. |
First attempt at using the correct
threadId/workerIdfor the worker when inchild_processmode.process.envprocess.__tinypool_state__.workerIdfrom the env variable