Add recursion limit for dynamic code #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent stack exhaustion on: Decoder: * CopyNext * Skip * ReadIntf * ReadMapStrIntf * WriteToJSON Standalone: * Skip * ReadMapStrIntfBytes * ReadIntfBytes * CopyToJSON * UnmarshalAsJSON Limit is set to 100K recursive map/slice operations.
philhofer
approved these changes
Sep 6, 2024
mx-psi
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Sep 11, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tinylib/msgp](https://github.com/tinylib/msgp) | `v1.2.0` -> `v1.2.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>tinylib/msgp (github.com/tinylib/msgp)</summary> ### [`v1.2.1`](https://github.com/tinylib/msgp/releases/tag/v1.2.1) [Compare Source](https://github.com/tinylib/msgp/compare/v1.2.0...v1.2.1) ##### What's Changed - Add an unsafe flag so we can continue to use unsafe even when purego … by [@​jenn-k-f](https://github.com/jenn-k-f) in [https://github.com/tinylib/msgp/pull/356](https://github.com/tinylib/msgp/pull/356) - Add pointer receiver directive by [@​klauspost](https://github.com/klauspost) in [https://github.com/tinylib/msgp/pull/357](https://github.com/tinylib/msgp/pull/357) - ci: Add Go 1.23.x - remove Go 1.20.x by [@​klauspost](https://github.com/klauspost) in [https://github.com/tinylib/msgp/pull/359](https://github.com/tinylib/msgp/pull/359) - Add recursion limit for dynamic code by [@​klauspost](https://github.com/klauspost) in [https://github.com/tinylib/msgp/pull/358](https://github.com/tinylib/msgp/pull/358) ##### New Contributors - [@​jenn-k-f](https://github.com/jenn-k-f) made their first contribution in [https://github.com/tinylib/msgp/pull/356](https://github.com/tinylib/msgp/pull/356) **Full Changelog**: tinylib/msgp@v1.2.0...v1.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent adversarial stack exhaustion on:
Decoder:
Standalone:
Limit is set to 100K recursive map/slice operations. I know it is insanely high, but we are really just trying to not run out of stack.