Add Go v1.22.x to CI workflow #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it is ok to remove 1.18 support. It is far beyond EOL. |
klauspost
reviewed
Jul 1, 2024
VirrageS
force-pushed
the
add-1.22-golang
branch
3 times, most recently
from
4642245
to
0724472
Compare
|
@klauspost It is your call, I can keep 1.18 for now. |
|
Remove it in the PR. Having 4 versions back should be more than enough. Giving @philhofer a bit of time to object :) |
|
From what I see the philhofer/fwd@fbbf495 requires at least 1.20. And based on the output of Go 1.22 test, it seems to require that we use this new |
|
I'm not going to object to that. Personally I support last 3 versions, which is already one more than Go, but I don't know if Phil has an opinion on this. I suggest you add that to this PR, we can adjust if needed. |
VirrageS
force-pushed
the
add-1.22-golang
branch
3 times, most recently
from
75c7568
to
3bcbd1d
Compare
Signed-off-by: Janusz Marcinkiewicz <[email protected]>
|
Dropping support for EOL'd go versions is fine to me. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
1.22.xGo version to CI workflow so we also test against this version to make sure everything works fine.