Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlink, examples: use 'ninafw' tag instead of individual board tags #640

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

deadprogram
Copy link
Member

This PR modifies netlink and also the associated examples to use the 'ninafw' tag instead of individual board tags to simplify maintenance. Also see PR #4085 in the main TinyGo repo.

@deadprogram
Copy link
Member Author

Note that #4085 in the main repo has to be merged for this PR to pass the CI tests.

…to simplify maintenence. Also see PR #4085 in the main TinyGo repo

Signed-off-by: deadprogram <[email protected]>
@deadprogram
Copy link
Member Author

Now that tinygo-org/tinygo#4085 has been merged, this PR is ready.

Copy link
Contributor

@ysoldak ysoldak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable!

@deadprogram
Copy link
Member Author

Thanks for review @ysoldak now merging.

@deadprogram deadprogram merged commit 3c5e174 into dev Jan 17, 2024
@deadprogram deadprogram deleted the ninafw-tag branch January 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants